complete loading single items

kontor-api/src/db/repository/comics/comic.py

@@ -4,31 +4,26 @@ from sqlalchemy.orm import Session
 
 from src.core.log_conf import logger
 from src.db.models.comic import Comic, Issue
-from src.schema.comics.artist import ArtistResponse
-from src.schema.comics.comic import ComicResponse, ComicSchema
+from src.schema.comics.artist import artist_to_response
+from src.schema.comics.comic import ComicSchema, comic_to_response
 from src.schema.comics.comic_details import ComicDetailsResponse, ComicWorktypeArtistResponse
-from src.schema.comics.issue import IssueResponse
+from src.schema.comics.issue import IssueResponse, issue_to_response
 from src.schema.comics.issue_details import IssueDetailsResponse
-from src.schema.comics.publisher import PublisherResponse
-from src.schema.comics.volume import VolumeResponse
-from src.schema.comics.worktype import WorktypeResponse
-
-
-def list_comics(db: Session) -> List[Comic]:
-    comics = db.query(Comic).all()
-    return comics
+from src.schema.comics.publisher import publisher_to_response
+from src.schema.comics.volume import VolumeResponse, volume_to_response
+from src.schema.comics.worktype import worktype_to_response
 
 
 def get_issue_details(issue: Issue) -> IssueDetailsResponse:
     volume = None
     if issue.volume:
-        volume = VolumeResponse(id=issue.volume.id, name=issue.volume.name)
+        volume = volume_to_response(issue.volume)
     response = IssueDetailsResponse(
         id=issue.id,
         issue_number=str(issue.issue_number),
         in_stock=bool(issue.in_stock),
         is_read=bool(issue.is_read),
-        comic=ComicResponse(id=issue.comic.id, title=issue.comic.title, completed=issue.comic.completed),
+        comic=comic_to_response(issue.comic),
         volume=volume
     )
     return response
@@ -39,39 +34,26 @@ def update_comic(new_comic: ComicSchema, comic_id: str, db: Session) -> Optional
     comic: Optional[Comic] = db.get(Comic, comic_id)
     return comic
 
-def get_short_info(comic: Comic) -> ComicResponse:
-    response = ComicResponse(
-        id=comic.id,
-        title=str(comic.title),
-        completed=bool(comic.completed == 1)
-    )
-    return response
-
 def get_comic_details(comic: Comic) -> ComicDetailsResponse:
     volumes: List[VolumeResponse] = []
     for volume in comic.volumes:
-        volumes.append(VolumeResponse(id=volume.id, name=volume.name))
+        volumes.append(volume_to_response(volume))
     issues: List[IssueResponse] = []
     for issue in comic.issues:
-        issues.append(IssueResponse(
-            id=issue.id,
-            issue_number=issue.issue_number,
-            in_stock=issue.in_stock,
-            is_read=issue.is_read
-        ))
+        issues.append(issue_to_response(issue))
     works: List[ComicWorktypeArtistResponse] = []
     works_map: Dict[str, ComicWorktypeArtistResponse] = {}
     for work in comic.comic_works:
         worktype_id = work.work_type.id
         if worktype_id in works_map:
-            artist = ArtistResponse(id=work.artist.id, name=work.artist.name)
+            artist = artist_to_response(work.artist)
             works_map[worktype_id].artists.append(artist)
             logger.info(f"add artist to response map: {artist} -> {works_map}")
             print(f"add artist to response map: {artist} -> {works_map}")
         else:
             works_map[worktype_id] = ComicWorktypeArtistResponse(
-                worktype=WorktypeResponse(id=worktype_id, name=work.work_type.name), 
-                artists=[ArtistResponse(id=work.artist.id, name=work.artist.name)]
+                worktype=worktype_to_response(work.work_type),
+                artists=[artist_to_response(work.artist)]
             )
     for value in works_map.values():
         works.append(value)
@@ -82,7 +64,7 @@ def get_comic_details(comic: Comic) -> ComicDetailsResponse:
         completed=bool(comic.completed),
         current_order=bool(comic.current_order),
         weblink=str(comic.weblink),
-        publisher=PublisherResponse(id=comic.publisher.id, name=comic.publisher.name),
+        publisher=publisher_to_response(comic.publisher),
         issues=issues,
         volumes=volumes,
         works=works

kontor-api/src/db/repository/media.py

@@ -3,8 +3,7 @@ import uuid
 from datetime import datetime
 from src.core.log_conf import logger
 from src.db.models.media import MediaActor, MediaActorFile, MediaFile, MediaVideo
-from src.schema.media.actor import MediaActorModel, MediaActorResponse
-from src.schema.media.actorfile import MediaActorFileResponse
+from src.schema.media.actor import MediaActorModel
 from src.webapps.media.forms import AddLinkForm
 
 
@@ -12,7 +11,7 @@ def create_new_video(video: AddLinkForm, db: Session) -> MediaVideo:
     print(video.url)
     media_video = MediaVideo()
     media_video.id = str(uuid.uuid4())
-    media_video.url = video.url
+    media_video.url = str(video.url)
     media_video.created_date = datetime.now()
     media_video.last_modified_date = datetime.now()
     media_video.review = True
@@ -71,10 +70,6 @@ def delete_mediaactor(db: Session, actor_id: str):
     db.refresh(media_actor)
     db.delete(media_actor)
     db.commit()
-        
-def get_actor_details(media_actor: MediaActor) -> MediaActorResponse:
-    reponse: MediaActorResponse = MediaActorResponse(id=media_actor.id, name=str(media_actor.name), url=str(media_actor.url))
-    return reponse
 
 def create_new_mediaactorfile(db: Session, actor_id: str, file_id: str) -> MediaActorFile:
     logger.info(f"create MediaActorFile with actor {actor_id} and file {file_id}")
@@ -96,10 +91,3 @@ def delete_mediaactorfile(db: Session, actorfile_id: str):
     db.delete(media_actorfile)
     db.commit()
         
-def get_actorfile_details(media_actorfile: MediaActorFile) -> MediaActorFileResponse:
-    response: MediaActorFileResponse = MediaActorFileResponse(
-        id=media_actorfile.id,
-        file_id=str(media_actorfile.media_file_id),
-        actor_id=str(media_actorfile.media_actor_id)
-    )
-    return response

kontor-api/src/db/repository/user.py

@@ -5,15 +5,14 @@ from src.core.log_conf import logger
 from src.db.models.admin import Assignment, Profile
 from sqlalchemy.orm import Session
 
-from src.schema.user.profile import ProfileModel, ProfileResponse
-
+from src.schema.user.profile import ProfileModel
 
 
 def create_new_profile(new_profile: ProfileModel, db: Session) -> Profile:
-    logger.info(f"create MediaActor with url {new_profile.user_name}")
+    logger.info(f"create MediaActor with url {new_profile.username}")
     profile: Profile = Profile()
     profile.id = str(uuid.uuid4())
-    profile.user_name = new_profile.user_name
+    profile.user_name = new_profile.username
     profile.first_name = new_profile.first_name
     profile.last_name = new_profile.last_name
     profile.created_date = datetime.now()
@@ -35,13 +34,6 @@ def delete_profile(db: Session, profile_id: str):
         db.delete(profile)
         db.commit()
 
-def get_profile_details(profile: Profile) -> ProfileResponse:
-    reponse: ProfileResponse = ProfileResponse(
-        id=profile.id, 
-        username=str(profile.user_name)
-    )
-    return reponse
-
 def delete_assignment(db: Session, assignment_id: str) -> None:
     logger.info(f"delete Assignment with id {assignment_id}")
     assignment: Optional[Assignment] = db.get(Assignment, assignment_id)