complete loading single items

kontor-api/src/db/repository/comics/comic.py

@@ -4,31 +4,26 @@ from sqlalchemy.orm import Session
 
 from src.core.log_conf import logger
 from src.db.models.comic import Comic, Issue
-from src.schema.comics.artist import ArtistResponse
-from src.schema.comics.comic import ComicResponse, ComicSchema
+from src.schema.comics.artist import artist_to_response
+from src.schema.comics.comic import ComicSchema, comic_to_response
 from src.schema.comics.comic_details import ComicDetailsResponse, ComicWorktypeArtistResponse
-from src.schema.comics.issue import IssueResponse
+from src.schema.comics.issue import IssueResponse, issue_to_response
 from src.schema.comics.issue_details import IssueDetailsResponse
-from src.schema.comics.publisher import PublisherResponse
-from src.schema.comics.volume import VolumeResponse
-from src.schema.comics.worktype import WorktypeResponse
-
-
-def list_comics(db: Session) -> List[Comic]:
-    comics = db.query(Comic).all()
-    return comics
+from src.schema.comics.publisher import publisher_to_response
+from src.schema.comics.volume import VolumeResponse, volume_to_response
+from src.schema.comics.worktype import worktype_to_response
 
 
 def get_issue_details(issue: Issue) -> IssueDetailsResponse:
     volume = None
     if issue.volume:
-        volume = VolumeResponse(id=issue.volume.id, name=issue.volume.name)
+        volume = volume_to_response(issue.volume)
     response = IssueDetailsResponse(
         id=issue.id,
         issue_number=str(issue.issue_number),
         in_stock=bool(issue.in_stock),
         is_read=bool(issue.is_read),
-        comic=ComicResponse(id=issue.comic.id, title=issue.comic.title, completed=issue.comic.completed),
+        comic=comic_to_response(issue.comic),
         volume=volume
     )
     return response
@@ -39,39 +34,26 @@ def update_comic(new_comic: ComicSchema, comic_id: str, db: Session) -> Optional
     comic: Optional[Comic] = db.get(Comic, comic_id)
     return comic
 
-def get_short_info(comic: Comic) -> ComicResponse:
-    response = ComicResponse(
-        id=comic.id,
-        title=str(comic.title),
-        completed=bool(comic.completed == 1)
-    )
-    return response
-
 def get_comic_details(comic: Comic) -> ComicDetailsResponse:
     volumes: List[VolumeResponse] = []
     for volume in comic.volumes:
-        volumes.append(VolumeResponse(id=volume.id, name=volume.name))
+        volumes.append(volume_to_response(volume))
     issues: List[IssueResponse] = []
     for issue in comic.issues:
-        issues.append(IssueResponse(
-            id=issue.id,
-            issue_number=issue.issue_number,
-            in_stock=issue.in_stock,
-            is_read=issue.is_read
-        ))
+        issues.append(issue_to_response(issue))
     works: List[ComicWorktypeArtistResponse] = []
     works_map: Dict[str, ComicWorktypeArtistResponse] = {}
     for work in comic.comic_works:
         worktype_id = work.work_type.id
         if worktype_id in works_map:
-            artist = ArtistResponse(id=work.artist.id, name=work.artist.name)
+            artist = artist_to_response(work.artist)
             works_map[worktype_id].artists.append(artist)
             logger.info(f"add artist to response map: {artist} -> {works_map}")
             print(f"add artist to response map: {artist} -> {works_map}")
         else:
             works_map[worktype_id] = ComicWorktypeArtistResponse(
-                worktype=WorktypeResponse(id=worktype_id, name=work.work_type.name), 
-                artists=[ArtistResponse(id=work.artist.id, name=work.artist.name)]
+                worktype=worktype_to_response(work.work_type),
+                artists=[artist_to_response(work.artist)]
             )
     for value in works_map.values():
         works.append(value)
@@ -82,7 +64,7 @@ def get_comic_details(comic: Comic) -> ComicDetailsResponse:
         completed=bool(comic.completed),
         current_order=bool(comic.current_order),
         weblink=str(comic.weblink),
-        publisher=PublisherResponse(id=comic.publisher.id, name=comic.publisher.name),
+        publisher=publisher_to_response(comic.publisher),
         issues=issues,
         volumes=volumes,
         works=works